Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipping User Email case insensitive pedant test #311

Merged
merged 1 commit into from
May 28, 2021
Merged

Skipping User Email case insensitive pedant test #311

merged 1 commit into from
May 28, 2021

Conversation

jashaik
Copy link
Contributor

@jashaik jashaik commented May 11, 2021

Signed-off-by: jan shahid shaik [email protected]

Description

Chef Server is updated to support User Email case insensitive but chef-zero architecture is compatible to simulate this scenario.

Related Issue

Chef Server is updated to support User Email case insensitive but chef-zero architecture is incompatible to simulate this scenario.Hence skipping the Email case insensitive pedant test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Copy link
Contributor

@PrajaktaPurohit PrajaktaPurohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I assume the pipeline failure is unrelated to this PR.

@marcparadise
Copy link
Member

While the change looks OK, how much effort would it be to allow zero to support this usage? The goal for chef-zero is to maintain as much parity with server API as possible.

@jashaik
Copy link
Contributor Author

jashaik commented May 25, 2021

While the change looks OK, how much effort would it be to allow zero to support this usage? The goal for chef-zero is to maintain as much parity with server API as possible.

It would be good If someone having good experience in ruby data structures to answer this.
@PrajaktaPurohit Would you like to answer ?

@PrajaktaPurohit
Copy link
Contributor

chef/chef-server#2511 @marcparadise created an issue to track this for sometime in the future. We currently estimate this to take anywhere between a week to a sprint for a new dev on the server team to be able to dig into and fix.

@tas50 tas50 merged commit d39b972 into chef:master May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants