-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix undefined method .list on CookbookData #10
Conversation
Surprised that didn't trigger a fault in testing! Thanks! I'm going to wait an hour or two for other bugs to trickle in; let me know if you want a dot release now. |
fix undefined method .list on CookbookData
@jkeiser I can wait a bit. I also found another issue with loading cookbooks regarding a data doesn't exist error 1) Ridley::CookbookResource#latest_version when the cookbook has versions returns the latest version
Failure/Error: chef_cookbook(name, "1.2.0")
ChefZero::DataStore::DataAlreadyExistsError:
ChefZero::DataStore::DataAlreadyExistsError
# /Users/reset/code/chef-zero/lib/chef_zero/data_store/memory_store.rb:55:in `create_dir'
# /Users/reset/code/chef-zero/lib/chef_zero/server.rb:205:in `block in load_data'
# /Users/reset/code/chef-zero/lib/chef_zero/server.rb:198:in `each_pair'
# /Users/reset/code/chef-zero/lib/chef_zero/server.rb:198:in `load_data'
# ./spec/support/chef_server.rb:51:in `chef_cookbook'
# ./spec/unit/ridley/resources/cookbook_resource_spec.rb:40:in `block (4 levels) in <top (required)>' I was going to track it down when I had time before submitting a PR or issue |
Ah! I think I know what the cause of that issue is. Will submit a fix in a sec. Also, DOH. I know why travis wasn't catching this; I hadn't released a new chef-zero so the knife-essentials tests were running against the old one. |
Fix for that issue (I think) committed. I'm running down some other issues now. Terribly sorry; my mistake for not running rspecs of dependent projects before committing. |
@jkeiser don't worry bout it man! The list of dependent projects is only going to get bigger ;) |
Latest commit fixes all issues with knife-essentials specs (which touches the issues you mentioned). I have released 1.1.1 with the raft of fixes. Give it a whirl! |
OK, NOW it's actually released. That was fun. |
This function is referenced in
CookbookData.load_files
but it is referenced by the name.list
. Changed from.list_directory
to.list
.This will block you from being able to upload cookbooks into a Chef server