Testing ruby 3.0 and 3.1 #391
Conversation
Signed-off-by: poornima <[email protected]>
Signed-off-by: poornima <[email protected]>
Signed-off-by: poornima <[email protected]>
Signed-off-by: poornima <[email protected]>
Signed-off-by: poornima <[email protected]>
Signed-off-by: poornima <[email protected]>
Signed-off-by: poornima <[email protected]>
Signed-off-by: nikhil2611 <[email protected]>
Simplecov Report
|
Signed-off-by: nikhil2611 <[email protected]>
Signed-off-by: nikhil2611 <[email protected]>
Signed-off-by: nikhil2611 <[email protected]>
.byebug_history
Outdated
| @@ -0,0 +1,26 @@ | |||
| c | |||
There was a problem hiding this comment.
This file doesn't need to commit.
We can add this in .gitignore
There was a problem hiding this comment.
Added by mistake, I have removed it.
Signed-off-by: nikhil2611 <[email protected]>
Signed-off-by: nikhil2611 <[email protected]>
Signed-off-by: nikhil2611 <[email protected]>
Signed-off-by: nikhil2611 <[email protected]>
| @@ -5,5 +5,5 @@ | |||
| end | |||
|
|
|||
| Given(/^I create an empty data bag '(.+)'$/) do |databag| | |||
| run_command_and_stop "knife data bag create #{databag} -z -c config.rb", { fail_on_error: true } | |||
| run_command_and_stop "knife data bag create #{databag} -z -c config.rb", { fail_on_error: false } | |||
There was a problem hiding this comment.
Why did we need to set this to false? Is this failing with some error that needs to be addressed?
There was a problem hiding this comment.
we were already passing false to this function if you see, I just added the key because of the keyword argument and positional argument update in ruby 3.0 and 3.1.
So in the previous ruby versions it was working fine but after 3.0 its throwing error as it expects the key if we pass second argument.
.github/CODEOWNERS
Outdated
| @@ -2,4 +2,4 @@ | |||
|
|
|||
| * @chef/chef-workstation-reviewers @chef/chef-workstation-approvers @chef/chef-workstation-owners | |||
| .expeditor/ @chef/jex-team | |||
There was a problem hiding this comment.
@nikhil2611 feel free to remove this outdated team name
Signed-off-by: nikhil2611 <[email protected]>
Description
Updated the HTTPServerException to HTTPClientException to test ruby 3.0 and 3.1