Set environment before exec in chef-server-ctl psql #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
approved these changes
Nov 1, 2016
Setting the environment as part of the command leads to the password being revealed in ps output. Since this command exec's we can set the environment for the current process before exec. Signed-off-by: Steven Danna <[email protected]>
stevendanna
force-pushed
the
ssd/psql-no-password-in-ps
branch
from
e5b3f56 to
9387965
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the environment as part of the command leads to the password
being revealed in ps output. Since this command exec's we can set the
environment for the current process before exec.
Signed-off-by: Steven Danna [email protected]