Adds retry behavior for expander #978
Merged
+39
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 13, 2016 14:28
…of retries and wait time between retries configurable Signed-off-by: Paul Mooring <[email protected]>
Signed-off-by: Paul Mooring <[email protected]>
…ome state handling in the http_request_started and complete methods (as used by "post_to_solr"). This was fixed by forcing those methods to only run when retries is set to 0, because the method is recursive on failure the complete method is always run, but never more than once per document. Signed-off-by: Paul Mooring <[email protected]>
… and cookbook Signed-off-by: Paul Mooring <[email protected]>
stevendanna
approved these changes
Oct 22, 2016
| log.error { "Failed to post to solr (connection error): #{indexed_object}" } | ||
|
|
||
| if retries < max_retries | ||
| log.info { "Retrying solr connection: #{indexed_object} attempt #{retries}" } |
There was a problem hiding this comment.
Might be good for this to be something like "Retrying post to solr in #{retry_wait} seconds:" so that if you are tailing the logs you know about how long to wait before you get nervous again :D.
There was a problem hiding this comment.
I changed the message to
Retrying solr connection in RETRY_WAIT seconds: OBJECT attempt ATTEMPT_NUMBER
…xt retry Signed-off-by: Paul Mooring <[email protected]>
marcparadise
approved these changes
Oct 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently expander will drop jobs when solr is unavailable. This PR adds configurable options to expander for
max_retriesandretry_waitto allow expander to retry writing to solr for a configurable number of times. This allows Solr restarts without dropping tasks.