Remove nodejs from the final package #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@raskchanky or @smith or someone who has worked on oc_id. "Pretend" I know almost nothing about rails. Does this seem safe/reasonable to you? |
Encouraged by rails-coffee and uglifier, nodejs used up 51MB of disk space! In retaliation rm and rf teamed up at tribal council and voted her off the island. We've moved the two gems that require a javascript runtime into a new group in the Gemfile. They will still be installed by default, but `rake` and `rails server` won't require them by default when starting up. Signed-off-by: Steven Danna <[email protected]>
stevendanna
force-pushed
the
ssd/remove-nodejs
branch
from
f041958 to
a845fd2
Compare
|
@stevendanna AFAIK, the asset pipeline was the only reason for needing nodejs, so assuming the asset compilation stuff still works, then it's probably fine. I've never actually tried this myself, though, so I might be completely wrong. 😁 |
smith
approved these changes
Oct 5, 2016
There was a problem hiding this comment.
@stevendanna I think Josh is right. The node stuff is a build-time dependency in our case. I haven't tried this PR but what you did seems reasonable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encouraged by rails-coffee and uglifier, nodejs used up 51MB of disk
space! In retaliation rm and rf teamed up at tribal council and voted
her off the island.
We've moved the two gems that require a javascript runtime into a new
group in the Gemfile. They will still be installed by default, but
rakeandrails serverwon't require them by default when startingup.
Signed-off-by: Steven Danna [email protected]