Minor logrotate configuration fixes #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this @mhorbul! The changes look good. I'll run this through our CI and merge if there are no issues. |
| @@ -3,4 +3,4 @@ | |||
| PATH=/opt/opscode/embedded/sbin:$PATH | |||
|
|
|||
| command -v logrotate >/dev/null 2>&1 || exit 0 | |||
| nice -n 19 ionice -c3 logrotate /etc/opscode/logrotate.conf | |||
| nice -n 19 ionice -c3 logrotate -s /var/log/chef/logrotate.status /etc/opscode/logrotate.conf | |||
There was a problem hiding this comment.
Overall this looks good, my only question is whether /var/log/chef is the most appropriate path for this.
There was a problem hiding this comment.
good point. Let me move it to /var/log/opscode.
when SELinux is enabled on the box opscode logrotate updates fcontext of the status file every time it runs and that breaks default system logrotate process.
otherwise signal is sent to the nginx with the default configuration file which causes error.log being created in the wrong location. Also if SELinux is turned on the box, logrotate breaks due to the fact that the logrotate_exec_t service can not modify files labeled usr_t. Default error.log locates in the /opt/opscode/embedded/nginx/logs/error.log and labeled as usr_t.
|
This went through with no issue, and I've restarted the Travis job (looks a transient failure where the tests were terminated externally). Will merge once that's clear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following fixes in the logrotate configuration files allows to avoid issues on the boxes with SELinux enabled.