Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if pivotal.pem (and webui pair) exists, ensure permissions in default recipe #885

Merged
merged 1 commit into from
Jul 22, 2016

Conversation

srenatus
Copy link
Contributor

No description provided.

@@ -0,0 +1,57 @@
#
# Author:: Adam Jacob <[email protected]>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D maybe change this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I thought we'd just copy that around. ok, can do.

@rmoshier
Copy link
Contributor

LGTM 👍

file OmnibusHelper.bootstrap_sentinel_file do
owner "root"
group "root"
mode "0600"
content "You've been bootstrapped, punk. Delete me if you feel lucky. Do ya, Punk?"
content "You've been bootstrapped, punk. Delete me if you feel lucky. Do ya, punk?"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh maybe we should just update this message in general xD

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I've tried making it more meaningful now, including the time it was bootstrapped...

@tylercloke
Copy link
Contributor

I don't think there is a use case for the user wanting to have custom perms on the pivotal key? Cause this would overwrite them. Seems unlikely / like a bad idea. If not, 👍

@srenatus
Copy link
Contributor Author

@tylercloke: I don't think this is an issue. You can change the owner using attributes, but you shouldn't have anything less strict than 0600 on it, I guess.

@srenatus
Copy link
Contributor Author

I've had wilson do a build and test run, only ppc failed. (binaries here)

@stevendanna stevendanna merged commit e3f45b7 into master Jul 22, 2016
@srenatus srenatus deleted the sr/spool-89 branch July 22, 2016 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants