[IPO-202] Add initial Data Collector application and /_status check #858
Conversation
| @@ -89,6 +89,21 @@ module PrivateChef | |||
| backup Mash.new | |||
| backup["strategy"] = "tar" | |||
|
|
|||
| # | |||
There was a problem hiding this comment.
This comment might be more useful in the attributes file, that is where most of the other similar comments are.
|
Looks like this is on the right track. I'd like to understand better the background of data collector, and how it'll differ from the capture we are currently doing for analytics. It would also be helpful to separate out the changes that are formatting/indent/naming-related into their own PR. |
ryancragun
changed the title
ryancragun
force-pushed
the
jk/data_collector
branch
from
8882749 to
8cdfb6f
Compare
ryancragun
force-pushed
the
jk/data_collector
branch
from
8cdfb6f to
bc44cc5
Compare
| ]} | ||
| ]}, | ||
|
|
||
| <% if node['private_chef']['data_collector']['root_url'] && node['private_chef']['data_collector']['token'] %> |
There was a problem hiding this comment.
Per the RFC, the token is optional. Chef's commercial product that relies on Data Collector requires the token, but others' implementations may not.
jkeiser
force-pushed
the
jk/data_collector
branch
from
bc44cc5 to
54f0352
Compare
| {health_ping_modules, [ | ||
| oc_chef_authz, | ||
| chef_sql, | ||
| <% if node['private_chef']['data_collector']['root_url'] && node['private_chef']['data_collector']['token'] %> |
There was a problem hiding this comment.
Similar issue with && token here that adamleff mentioned below.
jkeiser
force-pushed
the
jk/data_collector
branch
from
ab407b6 to
54f0352
Compare
ryancragun
force-pushed
the
jk/data_collector
branch
from
54f0352 to
ef72418
Compare
|
http://wilson.ci.chef.co/job/chef-server-12-trigger-ad_hoc/189/downstreambuildview/ One test on one platform failed but it looks like a simple timeout. |
ryancragun
force-pushed
the
jk/data_collector
branch
from
ef72418 to
c1dfe24
Compare
| @@ -217,30 +217,19 @@ | |||
| ]} | |||
| ]}, | |||
|
|
|||
| {chef_objects, [ | |||
There was a problem hiding this comment.
Why is this being deleted?
|
A couple of comments, but overall this looks fine. I assume we'll add tests for update/1 once that is called from the application and more than a small stub method. |
| update(Body) when is_list(Body) -> | ||
| update(iolist_to_binary(Body)); | ||
| update(Body) -> | ||
| %% TODO: Transform to data collector JSON |
There was a problem hiding this comment.
Can we track this with a card instead of a source TODO?
There was a problem hiding this comment.
Yup, IPO-203 is for that implementation.
|
👍 once the deleted config is restored |
ryancragun
force-pushed
the
jk/data_collector
branch
from
c1dfe24 to
a6a9169
Compare
…erchef The data collector application is a forwarder of Chef Server actions to a remote server. This commit adds the configuration options for the required HTTP connection pool and remote server endpoint and authentication token. Author: Ryan Cragun <[email protected]> Signed-off-by: Ryan Cragun <[email protected]>
Add the data_collector oc_erchef application. When configured, the application will start an HTTP connection pool that will be used for POSTing data to the data collector endpoint. Add oc_chef_wm health callbacks. When configured the data_collector will hook into the /_status endpoint and report the remote server health. Signed-off-by: Ryan Cragun <[email protected]>
Signed-off-by: Ryan Cragun <[email protected]>
ryancragun
force-pushed
the
jk/data_collector
branch
from
a6a9169 to
2466413
Compare
The Data Collector application is intended to export Chef Server actions
to an external Data Collector server via HTTP requests. This PR adds:
and an HTTP connection pool.
been enabled.