Fix bug where requestor membership of public_key_read_access was not being properly tested for keys access. #817
+287
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| list_client_keys(org_name, test_client_name_2, other_requestor).should look_like(:status => 403) | ||
| end | ||
|
|
||
| it 'the second actor an no longer get client keys, returning a 403', :authentication do |
|
This change looks good to me 👍 |
…being properly tested for keys access. Access to the org scoped user and client keys read endpoints are controlled by membership on the public_key_read_access group (which defaults to the users and clients groups); however, a bug resulted in testing membership on public_key_read_access for the member being requested instead of the requestor. This commit fixes that bug and adds regression tests.
tylercloke
force-pushed
the
tc/fix-keys-access-group
branch
from
e316904 to
409002c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Access to the org scoped user and client keys read endpoints are controlled by membership on the public_key_read_access group (which defaults to the users and clients groups); however, a bug resulted in testing membership on public_key_read_access for the member being requested instead of the requestor.
This commit fixes that bug and adds regression tests.
Passing build