[oc_id] Set HOME in oc_id's runsv script #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream omnibus-software no longer builds Ruby with readline. This means that 'require "readline"' now picks up the rb-readline that oc_id installs into our ruby environment. Bundler internally does a require on readline during `bundle exec`. Unfortunately rb-readline fails if it is required with HOME unset. This leads to oc_id failing to start. This is similar to 5e7d19b
stevendanna
force-pushed
the
ssd/oc_id-home
branch
from
7449b6a to
bd6c248
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream omnibus-software no longer builds Ruby with readline. This
means that 'require "readline"' now picks up the rb-readline that oc_id
installs into our ruby environment. Bundler internally does a require on
readline during
bundle exec. Unfortunately rb-readline fails if it isrequired with HOME unset. This leads to oc_id failing to start.
This is similar to 5e7d19b