Split keys_spec.rb into user_, client_keys_spec.rb #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 For some background, user multi-key is troublesome in some modes of Chef Zero operation that don't support multi-org (like when using ChefFS). The way the tests were organized before, you could skip the actual tests by tagging them appropriately, but many of the |
|
Running it through wilson http://wilson.ci.chef.co/job/chef-server-12-trigger-ad_hoc/53/downstreambuildview/ |
- Skip multiuser setup on servers that don't support multiuser. - Don't use same org in all tests.
|
Fixed issues with erchef (hopefully), running a new job on Wilson now: http://wilson.ci.chef.co/job/chef-server-12-trigger-ad_hoc/54/downstreambuildview/ |
|
👍 Looks reasonable. |
jrunning
added a commit
that referenced
this pull request
Feb 22, 2016
Split keys_spec.rb into user_, client_keys_spec.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports work to bring chef-zero closer to parity with chef-server. See chef/chef-zero#199.