Fixing upgrade instructions in package postinstall script #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-dufour
force-pushed
the
ad/upgrade-instructions
branch
from
e566071 to
d5ac1fb
Compare
andy-dufour
force-pushed
the
ad/upgrade-instructions
branch
from
d5ac1fb to
267ee14
Compare
| @@ -40,6 +45,9 @@ if [ -e /etc/opscode/chef-server-running.json ]; then | |||
| echo | |||
| echo "(Add the '--no-op' option to see what would be removed by" | |||
| echo "this command)" | |||
| echo | |||
| echo "For verbose upgrade instructions please see:" | |||
There was a problem hiding this comment.
verbose -> detailed?
|
👍 This looks reasonable to me |
|
This also passed Wilson: http://wilson.ci.chef.co/job/chef-server-12-trigger-ad_hoc/48/ |
|
Love it! 👍 |
added 2 commits
February 5, 2016 13:25
…ons in package post-install script.
sdelano
force-pushed
the
ad/upgrade-instructions
branch
from
019d783 to
3cbc981
Compare
sdelano
added a commit
that referenced
this pull request
Feb 5, 2016
Fixing upgrade instructions in package postinstall script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #646
Simply adding some information via echo to tell the user they need to run chef-server-ctl start after the upgrade command completes.
Currently if you follow our post-install packages instructions explicitly you end up with a chef-server with all of its services down. Adding an explicit chef-server-ctl start and a link to our verbose docs upgrade instructions corrects the situation.