Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integration test cancellation #1942

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Fix integration test cancellation #1942

merged 1 commit into from
Mar 25, 2020

Conversation

snapp
Copy link
Contributor

@snapp snapp commented Mar 25, 2020 •
edited
Loading

Description

This PR fixes the integration test pipeline failing to cleanup instances that were orphaned during a pipeline cancellation. The issue was that expeditor's container environment does not have consul installed.

Signed-off-by: Christopher A. Snapp [email protected]

Check List

@snapp
Fix integration test cancellation
be466ff 
Signed-off-by: Christopher A. Snapp <[email protected]>
@snapp snapp requested a review from a team as a code owner March 25, 2020 16:56
@snapp snapp self-assigned this Mar 25, 2020
PrajaktaPurohit
PrajaktaPurohit approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@PrajaktaPurohit PrajaktaPurohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@PrajaktaPurohit PrajaktaPurohit merged commit a0bb18d into master Mar 25, 2020
@PrajaktaPurohit PrajaktaPurohit deleted the update_integration_tests branch March 25, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremiahsnapp jeremiahsnapp jeremiahsnapp approved these changes

@PrajaktaPurohit PrajaktaPurohit PrajaktaPurohit approved these changes

Assignees

@snapp snapp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snapp @jeremiahsnapp @PrajaktaPurohit