Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buildkite steps to the integration_test pipeline #1874

Merged
merged 4 commits into from
Jan 21, 2020

Conversation

snapp
Copy link
Contributor

@snapp snapp commented Dec 31, 2019

Description

This PR adds buildkite steps to the integration_test pipeline that execute specific terraform scenarios.

Issues Resolved

#1742

Check List

Sorry, something went wrong.

@snapp snapp requested a review from a team December 31, 2019 18:25
@snapp snapp requested a review from a team as a code owner December 31, 2019 18:25
Copy link
Contributor

@tduffield tduffield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to update the script to work without accepting parameters.

@snapp snapp force-pushed the csnapp/1742 branch 10 times, most recently from 09d96a4 to 5cd192a Compare January 2, 2020 21:24
Copy link
Contributor

@PrajaktaPurohit PrajaktaPurohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@tduffield tduffield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you update the default contact value for the AWS tag, I think you're good to go. This was a meaty bash script!

@snapp snapp force-pushed the csnapp/1742 branch 2 times, most recently from e2ff51f to 8b9a4b3 Compare January 17, 2020 21:15
@snapp
Copy link
Contributor Author

snapp commented Jan 17, 2020

@PrajaktaPurohit I've added a commit to this PR to reflect your request that the full test matrix be configured in buildkite.

@snapp snapp force-pushed the csnapp/1742 branch 2 times, most recently from 199556d to 5f06c9d Compare January 21, 2020 20:12
snapp added 3 commits January 21, 2020 13:31
If a buildkite pipeline fails or is cancelled sufficient signals are NOT
passed to the script that was running within a docker container to
allow the script to gracefully clean up after itself.

As such there is a high potential for orphaned resources to be left
running in AWS if this happens to the integration_test pipeline.

This commit attempts to add expeditor listeners to cancellation or
failures of the integration_test pipeline and attempt to perform the
cleanup of orphaned resources associated with the aborted job.

Signed-off-by: Christopher A. Snapp <[email protected]>
@PrajaktaPurohit PrajaktaPurohit merged commit 3c7ab76 into master Jan 21, 2020
@PrajaktaPurohit PrajaktaPurohit deleted the csnapp/1742 branch January 21, 2020 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants