Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Terraform scenario for external-postgres #1845

Merged
merged 1 commit into from
Nov 25, 2019

Conversation

PrajaktaPurohit
Copy link
Contributor

@PrajaktaPurohit PrajaktaPurohit commented Nov 23, 2019

Signed-off-by: Prajakta Purohit [email protected]

Description

This change lets us test external postgres with sslmode=disable in terraform.
Tested and passes on ubuntu16.04

@PrajaktaPurohit PrajaktaPurohit requested a review from a team November 23, 2019 01:46
provisioner "remote-exec" {
inline = [
"set -evx"
"echo \"deb http://apt.postgresql.org/pub/repos/apt/ xenial-pgdg main\" > /etc/apt/sources.list.d/pgdg.list"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably use the file provisioner for this.

Copy link
Contributor

@markan markan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@snapp snapp force-pushed the praj/scenario_for_external_postgres branch from ea46d76 to bfd469a Compare November 25, 2019 18:33
@PrajaktaPurohit PrajaktaPurohit merged commit 875614b into master Nov 25, 2019
@chef-expeditor chef-expeditor bot deleted the praj/scenario_for_external_postgres branch November 25, 2019 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants