Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lbaker/land erlang20 final #1813

Merged
merged 9 commits into from
Nov 15, 2019
Merged

Lbaker/land erlang20 final #1813

merged 9 commits into from
Nov 15, 2019

Conversation

PrajaktaPurohit
Copy link
Contributor

@PrajaktaPurohit PrajaktaPurohit commented Nov 4, 2019 •
edited by lbakerchef
Loading

Tasks

  • suppress gen_fsm deprecation warning
  • fix export_all compile errors
  • fix buildkite Erlang version
  • fix hoax compilation error
  • fix crypto:md5 and crypto:sha removal
  • upgrade rabbitmq
  • fix bcrypt deprecations
  • upgrade Erlang to version 20
  • employ SIGTERM fixes for Erlang 20
  • revert SIGTERM fixes for Erlang 19

Pipelines

https://buildkite.com/chef/chef-chef-server-master-verify/builds/860

https://buildkite.com/chef/chef-chef-server-master-omnibus-adhoc/builds/704#d40ef483-652b-4b52-b9a6-ca7b52380d69

@PrajaktaPurohit PrajaktaPurohit requested a review from a team November 4, 2019 22:47
@PrajaktaPurohit PrajaktaPurohit requested a review from a team as a code owner November 4, 2019 22:47
@lbakerchef lbakerchef force-pushed the lbaker/land-erlang20-final branch from a5ee6f3 to f9480bb Compare November 7, 2019 18:02
@lbakerchef lbakerchef self-assigned this Nov 7, 2019
@lbakerchef lbakerchef force-pushed the lbaker/land-erlang20-final branch 2 times, most recently from 91b0d89 to 8c66778 Compare November 7, 2019 22:49
PrajaktaPurohit
PrajaktaPurohit commented Nov 12, 2019
View reviewed changes
omnibus_overrides.rb Outdated Show resolved Hide resolved
@PrajaktaPurohit
Copy link
Contributor Author

PrajaktaPurohit commented Nov 12, 2019 •
edited by lbakerchef
Loading

some notes on commit messages:
1. fix buildkite erlang version [REMOVE AFTER REBASE] - this should not be removed, since that is required to point the pipeline to erlang 20 to run the unit tests. FIXED
2. Revert “Erl19.3.x SIGTERM changes cause runit failures.” - would be helpful to mention the reason for reverting this commit. ADDED TO COMMIT MSG

@lbakerchef lbakerchef force-pushed the lbaker/land-erlang20-final branch from 8c66778 to 73b61d2 Compare November 12, 2019 22:50
@lbakerchef
Revert "Erl19.3.x SIGTERM changes cause runit failures."
2df20a1 
This reverts commit be6a88b.

The fix for SIGTERM issues in Erlang 19 is different than the fix for
SIGTERM issues in Erlang 20, thus we need to remove the fix for 19 and
add the fix for 20.
@lbakerchef lbakerchef force-pushed the lbaker/land-erlang20-final branch 5 times, most recently from 4f882bf to 038271f Compare November 13, 2019 22:35
@lbakerchef
fix SIGTERM breakage for erlang 20.x
78c6a54 
Changes to SIGTERM handling in Erlang 19.x caused runit failures in
Chef Server. This was originally fixed when we upgraded to Erlang 19
by passing a startup flag to the Erlang VM on bootup.  But the startup
flag was removed in Erlang 20, so another fix had to be employed.

This change effectively reverts Erlang's SIGTERM handling to previous
(pre-19) behavior.

REF: erlang/otp#1315

Signed-off-by: Lincoln Baker <[email protected]>
@lbakerchef
upgrade to erlang 20
7182161 
Signed-off-by: Lincoln Baker <[email protected]>
@lbakerchef
fix bcrypt deprecations
1ab56bc 
Signed-off-by: Lincoln Baker <[email protected]>
@lbakerchef
upgrade rabbitmq to version 3.6.15
3dd666d 
Signed-off-by: Lincoln Baker <[email protected]>
@lbakerchef
fix crypto:md5 and crypto:sha removal
9044682 
Signed-off-by: Lincoln Baker <[email protected]>
@lbakerchef
fix hoax compilation error
7d8d6aa 
point to https://github.com/lbakerchef/hoax.

Signed-off-by: Lincoln Baker <[email protected]>
@lbakerchef
fix export_all compilation errors
92aba94 
Signed-off-by: Lincoln Baker <[email protected]>
@lbakerchef
suppress gen_fsm deprecation warning
0d5011e 
Signed-off-by: Lincoln Baker <[email protected]>
@lbakerchef lbakerchef force-pushed the lbaker/land-erlang20-final branch 2 times, most recently from a1284e7 to 0d5011e Compare November 14, 2019 22:57
@PrajaktaPurohit
Copy link
Contributor Author

Cannot approve since I opened the PR from a branch therefore putting it in a comment. LGTM!

@PrajaktaPurohit PrajaktaPurohit merged commit f40d541 into master Nov 15, 2019
@PrajaktaPurohit PrajaktaPurohit deleted the lbaker/land-erlang20-final branch November 15, 2019 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbakerchef lbakerchef lbakerchef left review comments

@markan markan markan approved these changes

Assignees

@lbakerchef lbakerchef

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PrajaktaPurohit @markan @lbakerchef