-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assume modern Linux in our haproxy omnibus builds #1764
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable and is quite welcome. My only hesitation with approving it is our main usage of haproxy is with chef-backend, and we don't currently have any testing around that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to try bumping this to at least 1.6.14 while we are here. As @markan says we should probably test this with chef-backend before release.
Hi @tas50 and @PrajaktaPurohit,
Note: while doing chef-backend cluster setup from /dev I required to do this changes https://gist.github.com/NAshwini/cb8ce51b6de4c8e050c149c86ad0f6bf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to hear it's passing tests, looks good to me.
@tas50 and @PrajaktaPurohit Anything pending on this PR ? can we go ahead and merge it? |
15d9f0c
to
8372bf7
Compare
fwiw, I've manually tested a build of this branch (13.1.50+20200220124407) using the I've also kicked off a full https://buildkite.com/chef/chef-chef-server-master-integration-test/builds/19 Note that ipv6 will continue to fail due to issues unrelated to this PR. |
1c4b801
to
8d7c7a3
Compare
2f96e56
to
f743cea
Compare
6ead109
to
a2adf42
Compare
This had been tested with chef-backend, including the chef-backend demotion scenario. https://buildkite.com/chef/chef-chef-server-master-integration-test/builds/24#_ (The builds show as failed because of some other changes not getting the expected exit code. But the tests are actually successful for chef-backend) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for digging through all the issues here!
We no longer support RHEL 5 or SLES 11 which were pre-Linux 2.6.28. We can now assume Linux 2.6.28 everywhere. Signed-off-by: Tim Smith <[email protected]>
No need to support this in the future Signed-off-by: Tim Smith <[email protected]>
Signed-off-by: Prajakta Purohit <[email protected]>
Signed-off-by: Prajakta Purohit <[email protected]> Signed-off-by: Christopher A. Snapp <[email protected]>
We no longer support RHEL 5 or SLES 11 which were pre-Linux 2.6.28. We can now assume Linux 2.6.28 everywhere.
Signed-off-by: Tim Smith [email protected]