Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assume modern Linux in our haproxy omnibus builds #1764

Merged
merged 4 commits into from
Feb 24, 2020
Merged

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Sep 23, 2019

We no longer support RHEL 5 or SLES 11 which were pre-Linux 2.6.28. We can now assume Linux 2.6.28 everywhere.

Signed-off-by: Tim Smith [email protected]

@tas50 tas50 requested a review from a team September 23, 2019 17:56
Copy link
Contributor

@markan markan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable and is quite welcome. My only hesitation with approving it is our main usage of haproxy is with chef-backend, and we don't currently have any testing around that.

Copy link
Contributor

@stevendanna stevendanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to try bumping this to at least 1.6.14 while we are here. As @markan says we should probably test this with chef-backend before release.

omnibus/config/software/haproxy.rb Outdated Show resolved Hide resolved
@PrajaktaPurohit PrajaktaPurohit added Status: Consider for next release Status: Sustaining Backlog An issue ideal for the Sustaining Engineering team (or anyone else if they want to adopt it). labels Oct 4, 2019
@NAshwini
Copy link
Member

NAshwini commented Nov 13, 2019

Hi @tas50 and @PrajaktaPurohit,
Done testing with chef-backend (2.0.30) and chef-server build from PR #1764. To create chef-server I was facing error There was an error parsing `Gemfile`: There are no gemspecs at /opt/opscode/embedded/lib/ruby/gems/2.6.0/gems/inspec-core-bin-4.16.0. Bundler cannot continue which was resolve with changes https://github.com/chef/chef-server/pull/1774/files.
Testing steps followed as:

  1. Ran chef-server-ctl test on fe1 and fe2. Got successful result with 172 examples, 0 failures, 2 pending as https://chefio.atlassian.net/secure/attachment/35567/35567_test_result_on_fe1
  2. Made Backend failover with similar steps
    as https://chefio.atlassian.net/secure/attachment/35561/35561_make+backend+failover
  3. Again Ran chef-server-ctl test on fe1 and fe2. Got same result as step 1.

Note: while doing chef-backend cluster setup from /dev I required to do this changes https://gist.github.com/NAshwini/cb8ce51b6de4c8e050c149c86ad0f6bf

Copy link
Contributor

@markan markan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to hear it's passing tests, looks good to me.

@shindemahendra
Copy link

@tas50 and @PrajaktaPurohit Anything pending on this PR ? can we go ahead and merge it?

@snapp
Copy link
Contributor

snapp commented Feb 20, 2020

fwiw, I've manually tested a build of this branch (13.1.50+20200220124407) using the omnibus-chef-backend scenario with ipv4 and it passed all of the chef-server tests.

I've also kicked off a full integration_test pipeline here:

https://buildkite.com/chef/chef-chef-server-master-integration-test/builds/19

Note that ipv6 will continue to fail due to issues unrelated to this PR.

@snapp snapp force-pushed the modern_linux branch 2 times, most recently from 2f96e56 to f743cea Compare February 20, 2020 22:12
@snapp snapp force-pushed the modern_linux branch 2 times, most recently from 6ead109 to a2adf42 Compare February 21, 2020 13:13
@PrajaktaPurohit PrajaktaPurohit removed Status: Consider for next release Status: Sustaining Backlog An issue ideal for the Sustaining Engineering team (or anyone else if they want to adopt it). labels Feb 21, 2020
@PrajaktaPurohit
Copy link
Contributor

This had been tested with chef-backend, including the chef-backend demotion scenario. https://buildkite.com/chef/chef-chef-server-master-integration-test/builds/24#_ (The builds show as failed because of some other changes not getting the expected exit code. But the tests are actually successful for chef-backend)

Copy link
Contributor

@stevendanna stevendanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging through all the issues here!

tas50 and others added 4 commits February 24, 2020 13:57
We no longer support RHEL 5 or SLES 11 which were pre-Linux 2.6.28. We can now assume Linux 2.6.28 everywhere.

Signed-off-by: Tim Smith <[email protected]>
No need to support this in the future

Signed-off-by: Tim Smith <[email protected]>
Signed-off-by: Prajakta Purohit <[email protected]>
Signed-off-by: Prajakta Purohit <[email protected]>
Signed-off-by: Christopher A. Snapp <[email protected]>
@PrajaktaPurohit PrajaktaPurohit merged commit dc122eb into master Feb 24, 2020
@chef-expeditor chef-expeditor bot deleted the modern_linux branch February 24, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants