Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to use ruby 2.5.6 #1756

Merged
merged 1 commit into from
Sep 23, 2019
Merged

Conversation

snapp
Copy link
Contributor

@snapp snapp commented Sep 20, 2019

The docker environment used by the verify pipeline bumped the ruby version from 2.5.5 to 2.5.6 which broke chef-server's verify testing since it was pinned to 2.5.5.

This build shows this PR fixes the verify pipeline:

https://buildkite.com/chef/chef-chef-server-master-verify/builds/457

Signed-off-by: Christopher A. Snapp <[email protected]>
@snapp snapp requested a review from a team September 20, 2019 19:11
@snapp snapp requested a review from a team as a code owner September 20, 2019 19:11
Copy link
Contributor

@markan markan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable. Is there a timeline to update to 2.6.x? CS is currently shipping with 2.6.3 in omnibus-overrides.

@lbakerchef lbakerchef mentioned this pull request Sep 23, 2019
2 tasks
@PrajaktaPurohit PrajaktaPurohit merged commit 29e6701 into master Sep 23, 2019
@chef-expeditor chef-expeditor bot deleted the csnapp/fix_verify_tests branch September 23, 2019 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants