Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the old delivery directory #1694

Merged
merged 1 commit into from
Aug 6, 2019
Merged

Remove the old delivery directory #1694

merged 1 commit into from
Aug 6, 2019

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Jul 1, 2019

We're not using delivery anymore so we shouldn't need this.

Signed-off-by: Tim Smith [email protected]

@tas50 tas50 requested a review from a team July 1, 2019 18:57
@tas50 tas50 requested a review from a team as a code owner July 1, 2019 18:57
Copy link
Contributor

@markan markan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm +1 for this. It looks like we have some vestigial stuff in old school delivery workflow (https://automate.chef.co/e/chef/#/organizations/products/projects/chef-server), but I don't think it has any use anymore.
@stevendanna @marcparadise do you agree?

@stevendanna
Copy link
Contributor

This was added by releng and is explained here:

https://github.com/chef/chef-server#acc-pipeline--chef-expeditor

and I believe the goal was to replace the qa-chef-server stuff with it: https://github.com/chef/chef-server/blob/master/RELEASE_PROCESS.md#testing-the-release

I'm personally fine removing this as I think that any process that depends on ACC should probably not be long for this world and that effort is better spent elsewhere.

That said, if we are going to remove this then we should probably also remove terraform/, cookbooks/chef-server-deploy/, and inspec/.

We're not using delivery anymore so we shouldn't need this.

Signed-off-by: Tim Smith <[email protected]>
@PrajaktaPurohit
Copy link
Contributor

Captured the issue in : #1713

@PrajaktaPurohit PrajaktaPurohit merged commit fdfe4e2 into master Aug 6, 2019
@chef-ci chef-ci deleted the delivery branch August 6, 2019 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants