Ma/license check #1674
Merged
Ma/license check #1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcparadise
reviewed
Jun 6, 2019
omnibus/files/private-chef-cookbooks/private-chef/libraries/private_chef.rb
Outdated
Show resolved
Hide resolved
marcparadise
reviewed
Jun 6, 2019
marcparadise
approved these changes
Jun 6, 2019
tyler-ball
suggested changes
Jun 7, 2019
markan
force-pushed
the
ma/license-check
branch
3 times, most recently
from
82f0d0d to
7687175
Compare
Move external dependencies earlier to avoid rebuilding them when internals change. Signed-off-by: Mark Anderson <[email protected]>
markan
force-pushed
the
ma/license-check
branch
3 times, most recently
from
6076725 to
e1f8f3b
Compare
|
Latest version is running in CI as https://buildkite.com/chef/chef-chef-server-master-omnibus-adhoc/builds/226 |
tyler-ball
reviewed
Jun 18, 2019
src/chef-server-ctl/Gemfile.lock
Outdated
| @@ -46,100 +47,122 @@ GEM | |||
| specs: | |||
| addressable (2.6.0) | |||
| public_suffix (>= 2.0.2, < 4.0) | |||
| appbundler (0.12.0) | |||
| appbundler (0.13.0) | |||
There was a problem hiding this comment.
Looks like the current build failures are because 0.13.0 got yanked from Rubygems. @lamont-granquist Do you know if this is expected?
tyler-ball
approved these changes
Jun 18, 2019
markan
force-pushed
the
ma/license-check
branch
3 times, most recently
from
4e11a36 to
b26bd81
Compare
Use chef 15, ruby 2.6.3, bundler 1.17.2 Signed-off-by: Mark Anderson <[email protected]>
Use Chef 15, and add license acceptance support to chef-server-ctl reconfigure Set license acceptance in environment so nested callouts to chef products work Signed-off-by: Mark Anderson <[email protected]>
This adds license acceptance in chef-server infrastructure to ensure that everything works correctly. Signed-off-by: Mark Anderson <[email protected]>
Chef 15 merges nil attributes differently that previous versions. In prior versions a nil with a higher precedence value is dropped in favor of non-nil values at a lower value. In Chef 15 a nil at a higher precedence value is respected. Signed-off-by: Mark Anderson <[email protected]>
Signed-off-by: Mark Anderson <[email protected]>
Signed-off-by: Mark Anderson <[email protected]>
Signed-off-by: Mark Anderson <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates to chef-15, which requires license acceptance, and adds a license acceptance requirement to chef-server-ctl reconfigure.
This reprises #1672 which was closed because of a github oops. (Don't delete the base branch of a live PR.)
Issues Resolved
[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussion that's relevant]
Check List