Ma/update runit #1668
Merged
Ma/update runit #1668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
approved these changes
May 17, 2019
| @@ -290,7 +290,7 @@ def generate_hash | |||
| results["private_chef"]["logs"]["log_retention"] = PrivateChef["log_retention"] | |||
| results["private_chef"]["logs"]["log_rotation"] = PrivateChef["log_rotation"] | |||
| results["private_chef"]["dark_launch"] = PrivateChef["dark_launch"] | |||
| results["private_chef"]["opscode-erchef"]["max_request_size"] = PrivateChef["opscode_erchef"]["max_request_size"] | |||
| # results["private_chef"]["opscode-erchef"]["max_request_size"] = PrivateChef["opscode_erchef"]["max_request_size"] | |||
There was a problem hiding this comment.
Intentional?
Update: of course! Found the commit. Sorry for the noise 😉
tyler-ball
reviewed
May 17, 2019
| end | ||
|
|
||
| link postgresql_data_dir_symlink do | ||
| to postgresql_data_dir | ||
| not_if { postgresql_data_dir == postgresql_data_dir_symlink } | ||
| end | ||
|
|
||
| File.open("/dotfiles/node.json", "w") do |f| f.write node.to_json end |
There was a problem hiding this comment.
Debugging code; I was trying to figure out some details of what was going on internally
markan
force-pushed
the
ma/update_runit
branch
7 times, most recently
from
6776ae5 to
33e042b
Compare
markan
force-pushed
the
ma/update_runit
branch
2 times, most recently
from
ceabaaf to
2264337
Compare
tas50
approved these changes
Jun 3, 2019
markan
force-pushed
the
ma/update_runit
branch
2 times, most recently
from
6f2f323 to
d781fee
Compare
Signed-off-by: Mark Anderson <[email protected]>
Signed-off-by: Mark Anderson <[email protected]>
Update Berksfile to use 5.1.1 runit Use enterprise-chef-common 0.15.1 Signed-off-by: Mark Anderson <[email protected]>
Signed-off-by: Mark Anderson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update to newest runit and enterprise-chef-common cookbooks. Necessary to be able to move to Chef 15. Still a bit broken, work in progress.
Built on top of ma/remove_drbd, because the new enterprise_chef_common cookbook removes some drbd/keepalived logic
Issues Resolved
[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussion that's relevant]
Check List