Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pedant to match new maximum request size #1661

Merged
merged 2 commits into from
Apr 12, 2019

Conversation

markan
Copy link
Contributor

@markan markan commented Apr 9, 2019

Description

Fixes build breakage from #1649.

Issues Resolved

#1649 wasn't totally complete. We updated the default but missed updating the pedant tests.

Check List

@markan markan requested a review from a team April 9, 2019 22:50
PR #1649 (merge 602381b) wasn't complete. We need to update pedant to test the new max request size.

Signed-off-by: Mark Anderson <[email protected]>
@markan markan force-pushed the ma/max_request_size_fixup branch from 37558f5 to 974287f Compare April 11, 2019 05:00
@@ -303,7 +303,7 @@
end

it "should not leak CouchDB '_rev' fields after committing a sandbox", :cleanup do
pending "Fix this in Erchef" do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this test?

Signed-off-by: Mark Anderson <[email protected]>
@markan markan force-pushed the ma/max_request_size_fixup branch from 974287f to 098a179 Compare April 11, 2019 22:14
@markan markan merged commit 35c58f7 into master Apr 12, 2019
@markan markan deleted the ma/max_request_size_fixup branch April 12, 2019 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants