Get habitat build working with changes from #1654 #1658
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pwd for building changed with #1654. Hopefully this makes it not matter Signed-off-by: Jay Mundrawala <[email protected]>
markan
reviewed
Apr 3, 2019
| @@ -23,11 +23,19 @@ pkg_binds_optional=( | |||
| [chef-server-ctl]="secrets" | |||
| ) | |||
|
|
|||
| # set_pwd gives a consistent current working directory when building | |||
There was a problem hiding this comment.
I admit I'm a little unclear about the impact of this; why is it necessary? How does it affect local package builds (non-expeditor)
There was a problem hiding this comment.
I think tom is going to do something slightly different. Basically, with the new build, it's doing the equivalent of build src/bifrost/habitat instead of what we were doing before build src/bifrost. Hab sets different working directories for these, and our plans relied on the working directory to work correctly, so they don't work with the new build changes
markan
approved these changes
Apr 3, 2019
|
@tduffield is doing stuff to fix this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pwd for building changed with #1654. Hopefully
this makes it not matter
Signed-off-by: Jay Mundrawala [email protected]