Server admin mutual TLS support #1591
Merged
+69
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Cragun <[email protected]>
markan
force-pushed
the
server-admin-mTLS-fix
branch
from
00c7458 to
2eecacb
Compare
|
Running tests as ad-hoc #183 |
markan
approved these changes
Nov 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is built on top of
ma/chef-server-ctl-configand should bemerged after. The relevant commit for review is 00c7458
This fix has been running regularly as part of a Habitatized Chef server
built from a branch containing a collection of patches. Moving this patch over
will help us get rid of that branch.
Our Habitatized Chef Server users mutual TLS authentication between all
components. This fixes various calls inside the chef-server-ctl commands
to pass relevant TLS options during bifrost API calls.
This is a separate PR from ma/chef-server-ctl-config only to avoid invalidating the testing that has been done on that branch.