Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the embedded env when running escript #1589

Merged
merged 1 commit into from
Dec 21, 2018

Conversation

stevendanna
Copy link
Contributor

This patch has been running regularly on a branch but had not yet
been ported over to here.

Signed-off-by: Ryan Cragun [email protected]

@stevendanna stevendanna requested a review from a team November 7, 2018 11:48
@markan markan force-pushed the fix-escript-interpreter branch from bae6f5c to 6601e31 Compare November 17, 2018 00:22
Copy link
Contributor

@markan markan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having some trouble getting this through CI; needs another look after the holiday.

@markan markan force-pushed the fix-escript-interpreter branch 2 times, most recently from 3cacf31 to bbe99e8 Compare December 6, 2018 03:08
@markan markan force-pushed the fix-escript-interpreter branch from bbe99e8 to d48865a Compare December 21, 2018 00:51
@stevendanna stevendanna force-pushed the fix-escript-interpreter branch from d48865a to 8c633f2 Compare December 21, 2018 09:59
@stevendanna stevendanna merged commit 359306d into master Dec 21, 2018
@stevendanna
Copy link
Contributor Author

I went ahead and merged this. Since none of the CI in this project tests this code, it is unlikely that CI issues were related to this change.

@chef-ci chef-ci deleted the fix-escript-interpreter branch December 21, 2018 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants