-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
increase authn:keygen_timeout for oc_erchef hab pkg #1579
increase authn:keygen_timeout for oc_erchef hab pkg #1579
Conversation
Bumping this is probablly fine, but 20 seconds seems very long. Is this testing something we can put in the pipeline and use it to choose a smaller value? Happy to just merge this as is though. |
@stevendanna sure! I can spin up the container stack and test some smaller values out today at the same time I'm validating #1573 😄 |
Signed-off-by: Jeremy J. Miller <[email protected]>
ad6e2cc
to
30db7c6
Compare
@stevendanna I consistently got timeouts with a value of |
5 seconds is exactly in the realm of what I would expect. I'm actually pretty surprised we don't see this fail more often at 1 seconds since we are forking a command that does crypto potentially at early boot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking approve. I'm happy with anything between 5s and your original if you find this isn't working. I reran the failed travis test to see if that was transient as I can't imagine how this affects those tests.
I just noticed we are using 20s over in A2: https://github.com/chef/a2/blob/master/components/automate-cs-oc-erchef/pkg/api/config_request.go#L52 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Speculating; but we have seen some platforms in FIPS mode take a long time to generate keys, so perhaps that's where the 20 seconds comes from.
I think 5 seconds is just fine for non-fips installs with decent randomness sources.
Description
This is a very simple change to the
oc_erchef
Hab package default configuration.We noticed that the
keygen_timeout
value was too small out of the box and would continually spam these warnings:Increasing to this proposed value yielded no adverse affects in our testing over the months and so I decided to just make it the new default 😄
Signed-off-by: Jeremy J. Miller [email protected]