Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old github changelog generator #1530

Merged
merged 1 commit into from
Aug 15, 2018
Merged

Remove old github changelog generator #1530

merged 1 commit into from
Aug 15, 2018

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Aug 1, 2018

This should all be unused at this point since we bump the changelog with expeditor.

Signed-off-by: Tim Smith [email protected]

@tas50 tas50 requested a review from a team August 1, 2018 02:11
Copy link
Contributor

@markan markan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generally +1 for this, but we should check with @stevendanna and @marcparadise to make sure there isn't some reason to keep it I'm missing

Copy link
Contributor

@stevendanna stevendanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine by me. I haven't looked recently at the kind of changelogs that expeditor produces, but my leaning is that there is more value in being in line with other projects than maintaining our own changelog scripts.

One thing that we might lose is the omnibus-version changes section of the changelog, but I'm not sure it matters to much.

@tas50
Copy link
Contributor Author

tas50 commented Aug 15, 2018

@stevendanna We could probably rig up a similar functionality in the promotion step if we really wanted, but I'd argue that sort of thing should just go in the release notes, which are still human managed.

@markan
Copy link
Contributor

markan commented Aug 15, 2018

You might need to kick the travis tests to rerun the failing test. Otherwise you should be able to rebase this and merge. (Please rebase before the merge, it makes things in git visualizers more legible.

This should all be unused at this point since we bump the changelog with expeditor.

Signed-off-by: Tim Smith <[email protected]>
@tas50
Copy link
Contributor Author

tas50 commented Aug 15, 2018

Rebase. We'll see now

@tas50 tas50 merged commit 176ceeb into master Aug 15, 2018
@markan markan deleted the changelog_gen branch September 5, 2018 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants