Update oc_id gems #1518
Merged
Update oc_id gems #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcparadise
approved these changes
Jul 5, 2018
robbkidd
approved these changes
Jul 6, 2018
stevendanna
approved these changes
Jul 8, 2018
There was a problem hiding this comment.
Seems reasonable to me. We have some basic oc_id pedant tests here: https://github.com/chef/chef-server/blob/master/oc-chef-pedant/spec/api/oc_id_spec.rb that we should make sure are passing.
marcparadise
reviewed
Jul 9, 2018
| @@ -413,7 +413,7 @@ GEM | |||
| activesupport (>= 4.2) | |||
| spring-commands-rspec (1.0.4) | |||
| spring (>= 0.9.1) | |||
| sprockets (2.12.4) | |||
There was a problem hiding this comment.
I just got a security alert on this, with a fix in version update to 2.12.5 so 👍 for timing :D
2.0 changed the `doorkeeper_for` controller method to a `before_action`. Update the UsersController. `link_to` and `form_for` were using the array method of modifying the URL helper to use based on object class. The forms were updated to use specific URL path helpers because the Application object has a namespace that confuses the helpers (e.g. Oauth::Doorkeeper::Application). Migration added to add a scopes column to oauth_applications. This feature is generally about authz and oc-id currently only really provides authn. Opted to add the migration to keep the database scheme in line with the attributes Doorkeeper expects will be on its models. Doorkeeper initializer updated based on template from the gem. Restricted the grant flows to the two types Chef services use. Signed-off-by: Robb Kidd <[email protected]>
The backward incompatible changes[1] do not apply to oc-id.
* oc-id doesn't use a mongodb backend.
* oc-id doesn't use either of the doorkeeper_*_render_options methods.
* oc-id doesn't use application-specific scopes (despite adding the
column to the database to support them) so the change in precedence
behavior does not apply.
[1] https://github.com/doorkeeper-gem/doorkeeper/blob/v3.1.0/NEWS.md#300-rc2
Doorkeeper initializer updated based on template from the gem.
Signed-off-by: Robb Kidd <[email protected]>
---
The backward incompatible changes[1][2] do not apply to oc-id. * oc-id is currently at Rails 4.2, ok to drop support for 4.1. * oc-id is currently running Ruby 2.4, ok to drop support for 2.0. * oc-id does not enable `reuse_access_token`, so token valid timing change shouldn't affect it. * oc-id already stores times in UTC. [1] https://github.com/doorkeeper-gem/doorkeeper/releases/tag/v4.0.0.rc1 [2] https://github.com/doorkeeper-gem/doorkeeper/releases/tag/v4.0.0.rc3 Doorkeeper initializer updated based on template from the gem. Signed-off-by: Robb Kidd <[email protected]>
active_record 4.2.8 pins this but doesn't manifest this in the gemspec for some reason, so we explicitly pin pg to ~> 0.15 Signed-off-by: Mark Anderson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update oc_id gems, particularly doorkeeper.