Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolving Foodcritic warnings & cleaning up licensing #1510

Merged
merged 15 commits into from
Jul 12, 2018
Merged

Resolving Foodcritic warnings & cleaning up licensing #1510

merged 15 commits into from
Jul 12, 2018

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Jun 12, 2018

1 change per commit.

@tas50 tas50 requested a review from a team June 12, 2018 23:08
markan
markan reviewed Jun 13, 2018
View reviewed changes
Copy link
Contributor

@markan markan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this.
I want to dig a bit into the licenses around the drbd-ha stuff to make sure that the relicense is proper, but otherwise this looks good to merge.

@markan markan force-pushed the cookbook_cleanup branch from 0efed78 to aff5c1a Compare July 12, 2018 03:14
markan
markan approved these changes Jul 12, 2018
View reviewed changes
Copy link
Contributor

@markan markan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this should be clean to merge

tas50 added 15 commits July 12, 2018 10:27
@tas50 @markan
why_run and use_inline_resources are the default now
cb2da98 
Resolves Foodcritic FC113 warnings

Signed-off-by: Tim Smith <[email protected]>
@tas50 @markan
Update copyrights to current & Chef Software
e49cb96 
Signed-off-by: Tim Smith <[email protected]>
@tas50 @markan
Add apache 2 license headers to files
13d4e43 
We set a lot of these files to all rights reserved which isn't correct. Add the proper license headers

Signed-off-by: Tim Smith <[email protected]>
@tas50 @markan
Move files out of the default directory
5c28a86 
This is a Chef 11 thing

Signed-off-by: Tim Smith <[email protected]>
@tas50 @markan
Align metadata and fix owner
380410b 
Signed-off-by: Tim Smith <[email protected]>
@tas50 @markan
Use a SPDX compliant license string
c4a3ed6 
Signed-off-by: Tim Smith <[email protected]>
@tas50 @markan
Resolve FC001 warning
88c6afb 
Signed-off-by: Tim Smith <[email protected]>
@tas50 @markan
Resolve FC005 warning
a7b09e8 
Signed-off-by: Tim Smith <[email protected]>
@tas50 @markan
Require Chef 14 in the metadata
7fd4504 
Signed-off-by: Tim Smith <[email protected]>
@tas50 @markan
Resolve FC104 warnings
7bab3a2 
Signed-off-by: Tim Smith <[email protected]>
@tas50 @markan
Add license files to resolve FC071
8d55fde 
Signed-off-by: Tim Smith <[email protected]>
@tas50 @markan
Don't use fully removed node.set
31ea6f6 
This would blow up a Chef 14 run

Signed-off-by: Tim Smith <[email protected]>
@tas50 @markan
Remove more use_inline_resource statements
09d08e3 
These are the default in Chef 13+

Signed-off-by: Tim Smith <[email protected]>
@tas50 @markan
Don't use kind_of in a custom resource
ca982b7 
Signed-off-by: Tim Smith <[email protected]>
@tas50 @markan
Remove extra file that snuck into the array
01219e3 
Signed-off-by: Tim Smith <[email protected]>
@markan markan force-pushed the cookbook_cleanup branch from aff5c1a to 01219e3 Compare July 12, 2018 17:27
rhass
rhass approved these changes Jul 12, 2018
View reviewed changes
Copy link
Contributor

@rhass rhass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

:shipit: Ship It! :shipit:

@tas50 tas50 merged commit 5c7c988 into master Jul 12, 2018
@markan markan deleted the cookbook_cleanup branch July 12, 2018 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markan markan markan approved these changes

@rhass rhass rhass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tas50 @markan @rhass