Allow find in gather-logs to follow symlinks. #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevendanna
approved these changes
Jun 5, 2018
srenatus
approved these changes
Jun 6, 2018
| @@ -93,7 +93,7 @@ for i in /opt/{chef,$path}*/version-manifest.txt \ | |||
| fi | |||
| done | |||
|
|
|||
| for i in `find /var/log/${path}* -type f -mmin -"$modified_within_last_x_minutes"`; do | |||
| for i in `find -L /var/log/${path}* -type f -mmin -"$modified_within_last_x_minutes"`; do | |||
There was a problem hiding this comment.
[unrelated] Hmm, looking at this, I wonder if the * behind ${path} really is needed. But I suppose it doesn't hurt either.
|
@teknofire You're good to merge, but please rebase onto master beforehand to keep the history clean. |
This is needed to fix an issue when users symlink another directory to `/var/log/opscode` and allows find to follow the symlink when searching for the log files to include. Signed-off-by: Will Fisher <[email protected]>
markan
force-pushed
the
will/gather-logs-follow-symlinks
branch
from
a1411ee to
02960c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to fix an issue when users symlink another directory
to
/var/log/opscodeand allows find to follow the symlink whensearching for the log files to include.
Signed-off-by: Will Fisher [email protected]