Ma/update pc and rebar #1495
Merged
Ma/update pc and rebar #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markan
force-pushed
the
ma/update_pc_and_rebar
branch
3 times, most recently
from
b105848 to
1ba9e48
Compare
markan
force-pushed
the
ma/update_pc_and_rebar
branch
3 times, most recently
from
a05c783 to
83fb01e
Compare
thommay
approved these changes
May 30, 2018
srenatus
approved these changes
May 30, 2018
| @@ -0,0 +1,2 @@ | |||
| {erl_opts, [debug_info]}. | |||
There was a problem hiding this comment.
Did you intend to commit this folder? 😉
Looks like there's been some breaking changes in port compiler (blt/port_compiler#43); I don't know what the change plan is there, but we are unlocked on this dep; we should lock it like we do everything else. Signed-off-by: Mark Anderson <[email protected]>
The author of port compiler was recommending it, and it seems like good general practice. Signed-off-by: Mark Anderson <[email protected]>
markan
force-pushed
the
ma/update_pc_and_rebar
branch
from
83fb01e to
5cf7789
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lock port compiler; it's the only thing we don't lock.
Update rebar to 3.5.0