Ma/update all the things #1482
Merged
Ma/update all the things #1482
+86
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a lot of stale dependencies in various corners, this is a simple refresh of those to clean things up. Signed-off-by: Mark Anderson <[email protected]>
lamont-granquist
approved these changes
Apr 6, 2018
|
the java options make my head hurty just a bit, but it looks correct. what it was doing before was very naughty. |
thommay
approved these changes
Apr 9, 2018
omnibus/config/software/cleanup.rb
Outdated
| delete "#{install_dir}/embedded/lib/ruby/gems/2.3.0/cache/*.gem" | ||
| delete "#{install_dir}/embedded/service/gem/ruby/2.3.0/cache/*.gem" | ||
| delete "#{install_dir}/embedded/lib/ruby/gems/2.4.0/cache/*.gem" | ||
| delete "#{install_dir}/embedded/service/gem/ruby/2.4.0/cache/*.gem" |
There was a problem hiding this comment.
could this just be .../ruby/2.*/cache/*.gem so we don't have to update every ruby version bump?
marcparadise
approved these changes
Apr 9, 2018
Bump Chef and Ohai to Chef 13. Update cookbooks for devvm and installation to be compatible with Chef 13. This fixes constructs that were deprecated or removed in Chef 13, including: + CHEF 4: Set is deprecated + CHEF 4: Only use map syntax for attributes + CHEF 3694: Remove resource cloning (accidental in this case) + CHEF 9: Chef::REST API removed + String attributes are frozen + Providers need to have provides clauses See https://docs.chef.io/release_notes.html and https://docs.chef.io/chef_deprecations_client.html for more details. Signed-off-by: Mark Anderson <[email protected]>
markan
force-pushed
the
ma/update_all_the_things
branch
from
a4ff989 to
6c2eed0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has two major parts: