Increase Net::HTTP / rest-client open_timeout #1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with Ruby v2.3.0 the default value for `open_timeout` changed from `nil` (disabled) to `60` seconds. This 60 second value remains in current released versions of Ruby which is why we continue to see this behavior in newer versions as well. ruby/ruby@52e1c3b This caused periodic test failures which were observed and documented when we originally moved from Ruby v2.2.6 to v2.3.3. e7a2ac8 More recently these timeouts have caused increase of erratic test failures on both TravisCI and internal Jenkins build for slower platforms. Rather than setting an `open_timeout` value of `nil` and disabling the `open_timeout` entirely I have chosen to set a 300 second timeout as a starting point for increasing the timeout value to allow for legitimate timeouts to occur rather than having test jobs get stuck indefinitely. Signed-off-by: Ryan Hass <[email protected]>
|
Special to thanks to @stevendanna for pointing out e7a2ac8 -- I wouldn't have found this without his help! =) |
stevendanna
approved these changes
Feb 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Ruby v2.3.0 the default value for
open_timeoutchanged fromnil(disabled) to60seconds. This 60 second value remains in current released versions of Ruby which is why we continue to see this behavior in newer versions as well.open_timeoutdefault value was introduced: ruby/ruby@52e1c3bThis caused periodic test failures which were observed and documented when we originally moved from Ruby v2.2.6 to v2.3.3.
More recently these timeouts have caused increase of erratic test failures on both TravisCI and internal Jenkins build for slower platforms. Rather than setting an
open_timeoutvalue ofniland disabling theopen_timeoutentirely I have chosen to set a 300 second timeout as a starting point for increasing the timeout value to allow for legitimate timeouts to occur rather than having test jobs get stuck indefinitely.Signed-off-by: Ryan Hass [email protected]