change to test ipv6 fix #1439
Merged
change to test ipv6 fix #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markan
force-pushed
the
ma/fix_ipv6_rabbitmq
branch
2 times, most recently
from
e1ba094 to
5c51bfd
Compare
We weren't properly wrapping the rabbitmq host address with [] when it was an IPv6 address. We need a more general audit and testing pass, but this is a start to fix the immediate issue. Signed-off-by: Mark Anderson <[email protected]>
markan
force-pushed
the
ma/fix_ipv6_rabbitmq
branch
from
5c51bfd to
e407015
Compare
jaymzh
approved these changes
Dec 18, 2017
tylercloke
approved these changes
Dec 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.