[rabbitmq] Remove guest user by default

[PrajaktaPurohit]

No description provided.

[srenatus]

Looks good -- I'd prefer one call to rmqctl less if possible, but don't worry about that if it's not simple 😉

[srenatus]

What would happen if we executed this unconditionally? Delete might be idempotent? Just wondering if we can save us a call to rabbitmqctl, since these are quite expensive 🤔

[PrajaktaPurohit]

Looks like we can save that call, changes made! thank you :)

[srenatus]

Hmm have you pushed that? My expectation -- if we can save a call -- would be to have this block as

execute "#{rmq_ctl} delete_user guest" do
  environment (rabbitmq_env)
  user opc_username
end

So, no only_if at all. Does that make sense? 😉

[markan]

LGTM

[stevendanna]

Looks good to me with or without the change @srenatus recommended.