Set the correct owner and permissions for SSL certificate and key #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaym
force-pushed
the
jdm/cert-key-perms
branch
from
ef53919 to
4394f62
Compare
schisamo
approved these changes
Aug 14, 2017
tduffield
suggested changes
Aug 14, 2017
jaym
force-pushed
the
jdm/cert-key-perms
branch
from
194355c to
1d68b7f
Compare
stevendanna
approved these changes
Aug 15, 2017
|
i think that makes sense, everything else is owned by root |
jaym
force-pushed
the
jdm/cert-key-perms
branch
from
1d68b7f to
d46c210
Compare
added 4 commits
August 15, 2017 06:47
This is a follow up to #1366 and #1368. This patch will set the owner of the ssl certificate and key to the user that is running rabbitmq/nginx. In #1366, we discovered that rabbitmq was expecting certs to be in the nginx directory, however that wasn't necessarily the case when the ssl certificate was not generated by private-chef-cookbooks. In these cases, the rabbitmq management interface would be completely broken as the certs we asked it to use were not there. After fixing that, #1368 was required because the custom certificate that was being set for the accpetance environment was owned by root and had the permissions 600, which meant the opscode user could not read it. Rabbitmq does not start as root like nginx, so rabitmq was unable to read the certificate. While #1368 got our environment working, I suspect others may run into a similar issue unless we explicitly set the owner and permissions on the files to what we expect. Signed-off-by: Jay Mundrawala <[email protected]>
This is now set correctly when running chef-server-ctl reconfigure Signed-off-by: Jay Mundrawala <[email protected]>
Signed-off-by: Jay Mundrawala <[email protected]>
Signed-off-by: Jay Mundrawala <[email protected]>
jaym
force-pushed
the
jdm/cert-key-perms
branch
from
d46c210 to
6e29bf7
Compare
tduffield
approved these changes
Aug 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #1366 and
#1368.
This patch will set the owner of the ssl certificate and key to the
user that is running rabbitmq/nginx. In #1366, we discovered that
rabbitmq was expecting certs to be in the nginx directory, however
that wasn't necessarily the case when the ssl certificate was not
generated by private-chef-cookbooks. In these cases, the rabbitmq
management interface would be completely broken as the certs we
asked it to use were not there. After fixing that, #1368 was required
because the custom certificate that was being set for the accpetance
environment was owned by root and had the permissions 600, which meant
the opscode user could not read it. Rabbitmq does not start as root like
nginx, so rabitmq was unable to read the certificate. While #1368 got
our environment working, I suspect others may run into a similar issue
unless we explicitly set the owner and permissions on the files to what
we expect.