Add tests for chef-server-running.json #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, this includes checking for values expected by Manage, Reporting, and Pushy Server. Some tests are there twice, but then this is because the values are used in two places (and thus kind of independent). Signed-off-by: Stephan Renatus <[email protected]>
Signed-off-by: Steven Danna <[email protected]>
Signed-off-by: Steven Danna <[email protected]>
Signed-off-by: Steven Danna <[email protected]>
Signed-off-by: Steven Danna <[email protected]>
Signed-off-by: Steven Danna <[email protected]>
srenatus
approved these changes
Jun 13, 2017
marcparadise
approved these changes
Jun 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Chef Server releases have broken compatibility with add-ons because we've changed the structure of
/etc/opscode/chef-server-running.json. This PR adds tests for the parts of that file required by the various add-ons, upgrades, and chef-server-ctl commands.These tests are organized according to the integration point that requires the key. As a result, some keys are tested a number of times.