Lazily evaluate ES version detection code #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Sgtpluck Thanks for getting this started! You'll need to add the DCO Sign-off to your commit. See here for details: https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco |
jaymalasinha
approved these changes
Jun 12, 2017
Signed-off-by: Davida Marion <[email protected]>
Sgtpluck
force-pushed
the
dm/lazy-elasticsearch
branch
from
de0b955 to
bba2432
Compare
phiggins
reviewed
Jun 12, 2017
| :helper => OmnibusHelper.new(node))) | ||
| :helper => OmnibusHelper.new(node)) | ||
| } | ||
| } |
There was a problem hiding this comment.
If the thing on line 51 is a hash, I think the curly brackets on lines 50 and 61 are unnecessary.
Minor fixup to ensure elastic_search_major_version is called inside the lazy block. Signed-off-by: Steven Danna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running against chef-backend, the external elasticsearch node is proxies by HAProxy, which is started by Chef Server. Thus, we need to make sure the ES version detection code runs at compile-time to avoid it getting ECONNREFUSED.