[pedant] Add sleep to re-indexing tests #1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My best guess for what is happening in Wilson is that we are hitting a race between the queue being empty and expander posting the data to solr. I'm pretty skeptical of this given that the search that is failing is often the /last/ search in a series of searches so there is already a large amount of time between seeing an empty queue and doing to failing search. The other issue I'm investigating is whether our queues_empty? function may be erroneously reporting empty queues, but perhaps this will help in the meantime. Signed-off-by: Steven Danna <[email protected]>
ksubrama
approved these changes
Jun 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My best guess for what is happening in Wilson is that we are hitting a
race between the queue being empty and expander posting the data to
solr.
I'm pretty skeptical of this given that the search that is failing is
often the /last/ search in a series of searches so there is already a
large amount of time between seeing an empty queue and doing the
failing search.
The other issue I'm investigating is whether our queues_empty?
function may be erroneously reporting empty queues, but perhaps this
will help in the meantime.
Signed-off-by: Steven Danna [email protected]