Mp/oc id missing all.svg #1267
Merged
Mp/oc id missing all.svg #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As an added benefit this will stop ocid logs from capturing an exception and stack trace on every hit. |
stevendanna
reviewed
May 11, 2017
| @@ -27,7 +27,7 @@ | |||
| # config.assets.css_compressor = :sass | |||
|
|
|||
| # Do not fallback to assets pipeline if a precompiled asset is missed. | |||
| config.assets.compile = false | |||
| config.assets.compile = true | |||
There was a problem hiding this comment.
Will this work if nodejs isn't installed on the machine?
There was a problem hiding this comment.
I did run through with node uninstalled - but I'll verify that if it's never ther for the precompile phase, it still behaves just in case something got generated and retained.
There was a problem hiding this comment.
I've confirmed that this works when there is never a node package installed.
Eenable compilation of missing assets, so that requests to `all.svg` no longer 404. This dependency is defined and added in chef-web-core. Building the assets in precompile generates everything includeing all-FINGERPRINT.svg, however Rails is not using the fingerprint in this case. This is a simple fix after exploring the asset generation and not finding a sane way to either a) get rails to use the fingerprint for this resource ; or b) get it to load the un-fingerprinted version out of the gem. Since this is the only missing asset, no impact is expected by enabling compilation of missing resources. Signed-off-by: Marc A. Paradise <[email protected]>
…ging Signed-off-by: Marc A. Paradise <[email protected]>
marcparadise
force-pushed
the
mp/oc-id-missing-all.svg
branch
from
43696d6 to
23140a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable compilation of missing assets, so that
requests to
all.svgno longer 404. Thisdependency is defined and added in chef-web-core.
Building the assets in precompile generates everything including
all-FINGERPRINT.svg, however Rails is not using the fingerprint
in this case.
This is a simple fix after exploring the asset generation and
not finding a sane way to either a) get rails to use
the fingerprint for this resource ; or b) get it to load the
un-fingerprinted version out of the gem.
Since this is the only missing asset, no impact is expected by
enabling compilation of missing resources.
Signed-off-by: Marc A. Paradise [email protected]