Exclude ldap in -running.json if disabled. #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevendanna
approved these changes
May 2, 2017
In addition: * Added a helper function to generat eh chef-server running content to OmnibusHelper * Moved solr filtering/logic there * made the content lazy so that it's not evaluated until we're done. Signed-off-by: Marc A. Paradise <[email protected]>
marcparadise
force-pushed
the
mp/do-not-write-ldap-block-when-disabled
branch
from
2777901 to
6981969
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that addons can continue to rely on the presence of the ldap key instead of
the internals to indicate whether ldap is enabled.
OmnibusHelper
Signed-off-by: Marc A. Paradise [email protected]