Set insecure_addon_compat to true by default #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change has the potential to break a lot of existing automation. Setting this to true for now will give users time to update. Signed-off-by: Steven Danna <[email protected]>
| @@ -571,7 +571,8 @@ def warn_if_cred_mismatch(opts) | |||
| # | |||
| def save_credentials_to_config | |||
| credentials.legacy_credentials_hash.each do |service, creds| | |||
| next if service == "chef-server" | |||
| # Ignore secrets added by add-ons and the keys | |||
| next if PrivateChef[service].nil? | |||
There was a problem hiding this comment.
Will this do the right thing for opscode-erchef vs opscode_erchef?
There was a problem hiding this comment.
I think any problems with that need to be cleared up before we get here, otherwise it would blow up with a NoMethodError [] on NilClass. However, this is a good thing to double check on.
There was a problem hiding this comment.
@marcparadise I've discussed and double-checked this with @stevendanna, it's catching a bug we had earlier when you'd do the following:
- install (a current package of) chef-server, set
insecure_addon_compat true, reconfigure - install a current addon, run its reconfigure
- run chef-server-ctl reconfigure again
it would then try to ingest all the secrets from veil into PrivateChef (to end up writing them to running.json), and it would fail when a service didn't exist with a key in PrivateChef.
srenatus
approved these changes
Mar 23, 2017
marcparadise
approved these changes
Mar 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change has the potential to break a lot of existing automation.
Setting this to true for now will give users time to update.
Signed-off-by: Steven Danna [email protected]