Fix pedant compare #1145
Merged
Fix pedant compare #1145
+22
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markan
force-pushed
the
ma/fix_pedant_compare
branch
from
55c643e to
beff6ab
Compare
srenatus
added a commit
to chef/chef-zero
that referenced
this pull request
Mar 14, 2017
Due to a bug in oc-chef-pedant[1], we'd never noticed that this doesn't return what it should return to match chef-server. [1]: chef/chef-server#1145 Signed-off-by: Stephan Renatus <[email protected]>
This was referenced Mar 14, 2017
When comparing elements of a hash, if an element is an array we exit if it matches, rather than continuing on to check the other keys. This is because we used 'return true' in the body of a all? loop, apparently intending to move to the next iteration of the loop, but instead exiting the whole function with an incorrect 'true'. Due to this bug in our rpsec matcher, we weren't correctly checking the results of various ACL tests. This corrects the test to match what we actually return, as the actual permissions seem sane and reasonable. Signed-off-by: Mark Anderson <[email protected]>
srenatus
force-pushed
the
ma/fix_pedant_compare
branch
from
beff6ab to
7765a27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When comparing elements of a hash, if an element is an array we exit
if it matches, rather than continuing on to check the other keys.
This is because we used 'return true' in the body of an all? loop,
apparently intending to move to the next iteration of the loop, but
instead exiting the whole function with an incorrect 'true'.