-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make private-chef::rabbitmq and partybus use veil #1123
Conversation
I've noticed that the |
@irvingpop new installs should be covered by the add_user calls -- they include a password, too. or am I missing something? :) |
My point was about password rotation - the way those not_if guards are written, they passwords will never be changed. |
@irvingpop I'm afraid I still don't get it. As of now, the passwords would be changed unconditionally (the change removes the |
Ah, I was tripped up by the |
f2df899
to
f44464d
Compare
4ebf12b
to
289e586
Compare
4978233
to
8b44b2a
Compare
Signed-off-by: Stephan Renatus <[email protected]>
Signed-off-by: Stephan Renatus <[email protected]>
Signed-off-by: Stephan Renatus <[email protected]>
Signed-off-by: Stephan Renatus <[email protected]>
7dc1958
to
ccaf4fd
Compare
This doesn't check the password, just sets it unconditionally
Rationale: checking if it's ok, and setting it if not is probably just
as expensive as just setting it unconditionally.
Also, when upgrading to 3.6.6, it takes an extra password change to
upgrade hashes from md5 to sha256 (new default).
Also changes the execute's name to "ensure password for rabbitmq user
..." so it's a little less confusing to have this executed on each
reconfigure.