[oc-chef-pedant] Don't directly depend on veil #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lamont-granquist
approved these changes
Mar 6, 2017
stevendanna
force-pushed
the
ssd/pedant-use-env
branch
from
93551e3 to
a4f291a
Compare
Because oc-chef-pedant has a number of downstream dependencies, the direct dependency on veil meant that veil was going to start leaking into a number of other repositories and packages. I don't think we want that until the API stabilizes a bit more and until it is a more robust libary. Signed-off-by: Steven Danna <[email protected]>
stevendanna
force-pushed
the
ssd/pedant-use-env
branch
from
a4f291a to
4689b7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because oc-chef-pedant has a number of downstream dependencies, the
direct dependency on veil meant that veil was going to start leaking
into a number of other repositories and packages. I don't think we
want that until the API stabilizes a bit more and until it is a more
robust libary.
Signed-off-by: Steven Danna [email protected]