Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up redis_password from lua configuration #1113

Merged
merged 1 commit into from
Mar 3, 2017

Conversation

stevendanna
Copy link
Contributor

The main change here is cleaning up the redis password from the nginx
lua scripts. It also ensures all access to the redis password happens
via veil.

@stevendanna
Copy link
Contributor Author

This is built on top of the SPOOL-528/keys branch, will rebase once that is merged.

@stevendanna stevendanna changed the title Clean up redis_password from lua configuration [hold] Clean up redis_password from lua configuration Mar 3, 2017
Copy link
Contributor

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c2ea953 👍

The main change here is cleaning up the redis password from the nginx
lua scripts. It also ensures all access to the redis password happens
via veil.

Signed-off-by: Steven Danna <[email protected]>
@stevendanna stevendanna force-pushed the ssd/moar-redis-passwords branch from c2ea953 to 100df17 Compare March 3, 2017 14:41
@stevendanna stevendanna changed the title [hold] Clean up redis_password from lua configuration Clean up redis_password from lua configuration Mar 3, 2017
Copy link
Member

@marcparadise marcparadise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@srenatus srenatus merged commit c7d8452 into master Mar 3, 2017
@stevendanna stevendanna deleted the ssd/moar-redis-passwords branch March 7, 2017 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants