Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OpenSSL::Digest instead of Digest for FIPS #1035

Merged
merged 1 commit into from
Dec 19, 2016
Merged

Conversation

btm
Copy link
Contributor

@btm btm commented Dec 15, 2016

Low level API calls to encryption algorithms are not allowed when using the
OpenSSL FIPS 140-2 module. When FIPS mode is enabled, all calls must go through
the FIPS module.

Fixes #1024

Signed-off-by: Bryan McLellan [email protected]

Low level API calls to encryption algorithms are not allowed when using the
OpenSSL FIPS 140-2 module. When FIPS mode is enabled, all calls must go through
the FIPS module.

Fixes #1024

Signed-off-by: Bryan McLellan <[email protected]>
@btm
Copy link
Contributor Author

btm commented Dec 15, 2016

We might need some backstory from Ryan Cragun on 3ff412b, but mostly I think we were unaware of the consequences of not using OpenSSL::Digest.

@btm btm requested a review from ryancragun December 15, 2016 21:38
Copy link
Contributor

@stevendanna stevendanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I believe are you are correct in us just not knowing the consequences. Might be nice to have a lint check for that somewhere.

@ryancragun
Copy link
Contributor

I think the only reason for preferring digest over openssl is that by using the former you don't have to include all of openssl in your application, but I'm sure there are probably other reasons. I just used it because it's simple and small. As the functions have identical output this change should be fine. 👍

@stevendanna stevendanna merged commit d6d1d37 into master Dec 19, 2016
@btm btm deleted the btm/veil-fix-fips branch December 19, 2016 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants