Pass email address along when resetting password #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mivok
force-pushed
the
mh/id_password_reset
branch
from
2f800f2 to
df5e2d3
Compare
stevendanna
approved these changes
Dec 10, 2016
srenatus
approved these changes
Jan 20, 2017
The signature verification code uses the username, email address and expiry parameters to validate the signature (see src/oc-id/app/models/signature.rb), but we don't pass it along as a hidden form parameter. This means that all password reset attempts fail with a signature doesn't match message. Passing along the email address as well fixes this. Signed-off-by: Mark Harrison <[email protected]>
stevendanna
force-pushed
the
mh/id_password_reset
branch
from
df5e2d3 to
0a1c666
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature verification code uses the username, email address and
expiry parameters to validate the signature (see
src/oc-id/app/models/signature.rb), but we don't pass it along as a
hidden form parameter. This means that all password reset attempts fail
with a signature doesn't match message. Passing along the email address
as well fixes this.