Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept passwords with special chars in chef-server-ctl password #1005

Merged
merged 1 commit into from
Nov 23, 2016

Conversation

stevendanna
Copy link
Contributor

chef-server-ctl password delegates to knife-opc. In doing so, it was
not escaping special characters in the user supplied data. Now, it
does.

Fixes #366

Signed-off-by: Steven Danna [email protected]

Copy link
Contributor

@smith smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gif-keyboard-5574911569567219730

Copy link
Contributor

@tylercloke tylercloke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chef-server-ctl password delegates to `knife-opc`. In doing so, it was
not escaping special characters in the user supplied data.  Now, it
does.

Fixes #366

Signed-off-by: Steven Danna <[email protected]>
@stevendanna stevendanna force-pushed the ssd/escape-ctl-password branch from 7c94841 to 6111264 Compare November 23, 2016 12:10
@stevendanna stevendanna merged commit caf0ea2 into master Nov 23, 2016
@stevendanna stevendanna deleted the ssd/escape-ctl-password branch December 7, 2016 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants